fix: add useExternalService as option in assetSelector#7545
Open
sahar-fehri wants to merge 3 commits intomainfrom
Open
fix: add useExternalService as option in assetSelector#7545sahar-fehri wants to merge 3 commits intomainfrom
sahar-fehri wants to merge 3 commits intomainfrom
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
| state, | ||
| opts: SelectAccountGroupAssetOpts = defaultSelectAccountGroupAssetOpts, | ||
| ): AssetsByAccountGroup => | ||
| selectAllAssets(state, { useExternalServices: opts.useExternalServices }), |
There was a problem hiding this comment.
Bug: New opts object breaks selector memoization chain
The inline object { useExternalServices: opts.useExternalServices } is created fresh on every call to the first input selector. Since selectAllAssets and selectAllMultichainAssets use default reselect memoization (strict reference equality), this new object reference invalidates their cache on every call. The expensive computation inside selectAllMultichainAssets — including parsing CAIP assets, building balance maps, and fiat conversions — will rerun even when the state hasn't changed. Before this change, selectAllAssets was called directly as an input selector without opts, so its memoization worked correctly.
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Explanation
This PR adds a useExternalServices option to the token selectors, allowing callers to exclude non-EVM (multichain) assets when basic functionality / external services are disabled.
Added a useExternalServices option that:
Short-circuits early in
selectAllMultichainAssetswhenfalse, returning an empty object immediatelyAvoids all expensive computation (parsing CAIP assets, building balances, fiat conversions) when multichain assets aren't needed
Defaults to true to maintain backward compatibility
References
Checklist
Note
Adds a
useExternalServicesoption to asset selectors to optionally exclude non‑EVM assets and short‑circuit multichain processing; updates tests and changelog.useExternalServicesoption toselectAllAssetsandselectAssetsBySelectedAccountGroup(defaults totrue).selectAllMultichainAssets, return{}whenuseExternalServicesisfalse, excluding non‑EVM (multichain) assets.optsthrough selectors to control inclusion of multichain assets.packages/assets-controllers/src/selectors/token-selectors.test.ts)useExternalServicesand default behavior.useExternalServiceswhere needed.useExternalServicesoption and behavior inpackages/assets-controllers/CHANGELOG.md.Written by Cursor Bugbot for commit a6eea22. This will update automatically on new commits. Configure here.